Skip to content

Commit

Permalink
tools: delete v8_external_snapshot.gypi
Browse files Browse the repository at this point in the history
Delete the v8_external_snapshot target from gyp and disable the
v8_use_external_startup_data option since it is never used anyway.

Refs: nodejs#29363 (comment)
Fixes: nodejs#28964
  • Loading branch information
ryzokuken committed Aug 29, 2019
1 parent 17a697c commit 5adb3c1
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 210 deletions.
12 changes: 3 additions & 9 deletions tools/v8_gypfiles/v8.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@
}]
],
},
'includes': ['toolchain.gypi', 'features.gypi', 'v8_external_snapshot.gypi'],
'includes': ['toolchain.gypi', 'features.gypi'],
'targets': [
{
'target_name': 'run_torque',
Expand Down Expand Up @@ -257,8 +257,8 @@
}, # generate_bytecode_builtins_list

{
# This rule delegates to either v8_snapshot, v8_nosnapshot, or
# v8_external_snapshot, depending on the current variables.
# This rule delegates to either v8_snapshot or v8_nosnapshot depending on
# the current variables.
# The intention is to make the 'calling' rules a bit simpler.
'target_name': 'v8_maybe_snapshot',
'type': 'none',
Expand All @@ -277,12 +277,6 @@
# to appear before libv8_snapshot.a so it's listed explicitly.
'dependencies': ['v8_base', 'v8_snapshot'],
}],
['v8_use_snapshot==1 and v8_use_external_startup_data==1 and want_separate_host_toolset==0', {
'dependencies': ['v8_base', 'v8_external_snapshot'],
}],
['v8_use_snapshot==1 and v8_use_external_startup_data==1 and want_separate_host_toolset==1', {
'dependencies': ['v8_base', 'v8_external_snapshot'],
}],
]
}, # v8_maybe_snapshot
{
Expand Down
201 changes: 0 additions & 201 deletions tools/v8_gypfiles/v8_external_snapshot.gypi

This file was deleted.

0 comments on commit 5adb3c1

Please sign in to comment.