Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot read commit tooltip as link text comes over it #18

Closed
ryu1kn opened this issue Apr 25, 2019 · 2 comments
Closed

Cannot read commit tooltip as link text comes over it #18

ryu1kn opened this issue Apr 25, 2019 · 2 comments
Labels
bug

Comments

@ryu1kn
Copy link
Owner

ryu1kn commented Apr 25, 2019

Screen Shot 2019-04-25 at 12 53 25 pm
@ryu1kn ryu1kn added the bug label Apr 25, 2019
@ryu1kn
Copy link
Owner Author

ryu1kn commented Apr 25, 2019

This can be resolved by not using href of a tag and use WebView's postMessage instead. I tried it and works fine, but reverted it in the below commit as it was not strictly needed to revive Annotator asap.

ea79f28

ryu1kn added a commit that referenced this issue Apr 25, 2019
@ryu1kn
[#18] Revert "[#17] Revert 2 commits"
66af220 
This reverts commit ea79f28.

Use WebView's postMessage to send control back to extension
ryu1kn added a commit that referenced this issue Apr 25, 2019
@ryu1kn
[#18] Do not interpret command URI in webView as we now don't use it
c99aab9
ryu1kn added a commit that referenced this issue Apr 25, 2019
@ryu1kn
[#18] Give extension context to the annotate command
57aa4c8
ryu1kn added a commit that referenced this issue Apr 25, 2019
@ryu1kn
[#18] Fixed tests
81e7220
@ryu1kn
Copy link
Owner Author

ryu1kn commented Apr 25, 2019

Released as v1.0.0

@ryu1kn ryu1kn closed this as completed Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ryu1kn