-
-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial support for Vacuum 1C STYTJ01ZHM (dreame.vacuum.mc1808) #952
Conversation
26475e8
to
ad58bee
Compare
@rytilahti i dont know why this build fails. Can you give me a hint? |
Hey, it's coming from using If you have installed pre-commit hooks, it will run automatically pre-commit, but you can also always run the tests run by the CI using For the JSON file, check out devtools directory and its README :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, some comments from a very brief initial review.
This will make #683 obsolete, right?
fcc930c
to
17bb15d
Compare
Thanks, but i did not change the heater.py file. On my machine there are no errors when running the pre-commit scripts:
|
@legacycode the precommit output looks odd, considering that there are more checks since #915 and the current master was checked clean... Anyway, that's not your problem, but please add an entry to the README.md for this new supported device, then this is ready to be merged! Note, that the API (including status enums) may be adapted in the future to allow common interface among different vacuum types to simplify using the library for downstream users (like homeassistant). |
0095396
to
538565b
Compare
@rytilahti I added the device to the readme file. |
538565b
to
15589bf
Compare
Thanks again for the PR, @legacycode! 🥇 |
I own a Vacuum 1C STYTJ01ZHM and added support for it. This PR is based on the branch https://github.com/rytilahti/python-miio/tree/dreame_miot_mc1808
I tested every method with my own device and they all are working.
BTW: Where can i find the technical json file? I have seen that the previous file was generated?
Thanks for your suggestions and best regards.