Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add method to load subdevices from dict (EU gateway support) #936

Merged
merged 1 commit into from
Feb 12, 2021

Conversation

starkillerOG
Copy link
Contributor

No description provided.

Copy link
Owner

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's get this in for the next release! 👍

@rytilahti rytilahti changed the title add EU_gateway support add method to load subdevices from dict (EU gateway support) Feb 12, 2021
@rytilahti rytilahti merged commit d1beeae into rytilahti:master Feb 12, 2021
@carloslindo
Copy link

@rytilahti @starkillerOG Sorry if my question is a stupid one, but I would like to know how long it normally takes or what are the next steps in the process since this PR is merged into master until the code is available in the Xiaomi Miio integration in Home Assistant.

Thank you

@rytilahti
Copy link
Owner

In this specific case, the situation is a bit more complex as it will require some more integration work. That being said, I'll try to find some time soonish (upcoming weekend, or the one after that, I'm currently busy with other responsibilities) to prepare a release.

@starkillerOG is currently doing great work on improving the homeassistant integration to use config flows which will be helpful for integrating this, too!

@carloslindo
Copy link

carloslindo commented Feb 18, 2021

Thank you for the update and all your work @starkillerOG @rytilahti

@rytilahti rytilahti mentioned this pull request Mar 13, 2021
@carloslindo
Copy link

After release 0.5.5 how long does it normally take to get the latest code in the Xiaomi Miio integration in Home Assistant?

@starkillerOG
Copy link
Contributor Author

@carloslindo the 0.5.5 version is already merged in the dev release of HomeAssistant.
I just started writing the code for the options flow to let the user use the EU gateway with miio-cloud

@starkillerOG
Copy link
Contributor Author

@carloslindo I just made the PR for homeassistant: home-assistant/core#47955

If you could try it out, that would be greath!

I will start testing it myself in the coming days.

@carloslindo
Copy link

@starkillerOG You mean after it gets released in the home-assistant core? Or can I try it from a dev release?

@starkillerOG
Copy link
Contributor Author

@carloslindo you can download the files from the linked PR, then run it as a custom component.
Will test myself a bit and then put some instructions here: #728

@carloslindo
Copy link

@starkillerOG Thank you. I will help with testing!

xvlady pushed a commit to xvlady/python-miio that referenced this pull request May 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants