added support for zhimi.humidifier.cb2 #917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zero734kr
reviewed
Jan 23, 2021
harusame3144
changed the title
zero734kr
approved these changes
Jan 23, 2021
syssi
reviewed
Jan 23, 2021
| @@ -180,6 +183,11 @@ def motor_speed(self) -> Optional[int]: | |||
| @property | |||
| def depth(self) -> Optional[int]: | |||
| """The remaining amount of water in percent.""" | |||
|
|
|||
| # MODEL_HUMIDIFIER_CB2 127 without water tank. 125 = 100% water | |||
| if self.device_info.model == MODEL_HUMIDIFIER_CB2: | |||
There was a problem hiding this comment.
You could introduce a new boolean property to indicate the water tank is detached.
There was a problem hiding this comment.
Hi @syssi - do you want to get this change already into this PR, or shall we merge this already for the next release?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.