Add support for zhimi.heater.mc2 #895
Conversation
miio/heater_miot.py
Outdated
|
|
||
| @property | ||
| def countdown_time(self) -> int: | ||
| """Countdown time.""" |
There was a problem hiding this comment.
What does this indicate? Time until the device gets turned off? Maybe the property naming should follow the same format as in heater?
There was a problem hiding this comment.
Exactly. The countdown_time field defines the number hours before the device goes off.
The problem here is that the spec defines this field as countdown_time while for miio heater it is delay_off_countdown. Shall I overwrite countdown_time to match the field name in heater (delay_off_countdown)?
There was a problem hiding this comment.
Okay, looking at the current code base, there are several instances of delay_off_countdown which returns the value in seconds.
So I'd say yes, it's better use that same naming scheme (and return the value in seconds even when the precision is much lower) just to be consistent.
|
@rytilahti fixed according to your comments. let me know if I missed anything |
|
This is great! Thanks! |
* Add support for zhimi.heater.mc2 * fixup! Fix docstring for HeaterMiot * fixup! Add zhimi.heater.mc2 to readme * fixup! Fix miot spec link * fixup! Add response example for heater * fixup! Rename brightness property of miot heater * fixup! Allow setting delay countdown in seconds * Add model info to docstring Co-authored-by: Teemu R <[email protected]>
This PR adds support for Xiaomi Mi Smart Space Heater S (zhimi.heater.mc2).
References: #880
miot spec: https://miot-spec.org/miot-spec-v2/instance\?type\=urn:miot-spec-v2:device:heater:0000A01A:zhimi-mc2:1
Details
Product:Mi Home UI:
Added unit tests as well as tested the new heater module on an actual device.
Please let me know if I missed anything.