Add support for Xiaomi Mijia STYJ02YM (viomi.vacuum.v7) #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rumpeltux
reviewed
Nov 23, 2019
syssi
approved these changes
Nov 23, 2019
* STYJ02YM: Add support for DND * STYJ02YM: Add support to change language. * STYJ02YM: Add support to switch button LEDs on/off
|
@rezmus @rumpeltux I just added some missing documentation & the carpetturbo setter. I think we can merge this as it is, new features can be added then later on as needed, or do you want to get some other features implemented before doing that? |
|
On the other hand, let's just merge this. It's simple to add new features on top of it later on, thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on findings done by @nqkdev and contributions by @rumpeltux - thanks a lot for help!
This is the initial PR to fix #550 - plenty of values are still unknown so any help is welcome!