Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moonlight: Provide property rgb as tuple #414

Merged
merged 7 commits into from
Nov 18, 2018

Conversation

syssi
Copy link
Collaborator

@syssi syssi commented Nov 17, 2018

No description provided.

@syssi syssi changed the title Moonlight: Provide the rgb property as tuple Moonlight: Provide property rgb as tuple Nov 17, 2018
@syssi
Copy link
Collaborator Author

syssi commented Nov 17, 2018

May be set_rgb should be improved, too and we need a method per direction? Do you prefer a name? @rytilahti

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 72.948% when pulling be7895a on syssi:feature/moonlight-return-rgb into 293c3a0 on rytilahti:master.

@coveralls
Copy link

coveralls commented Nov 17, 2018

Coverage Status

Coverage increased (+0.3%) to 73.117% when pulling 8fa7e2d on syssi:feature/moonlight-return-rgb into 293c3a0 on rytilahti:master.

@syssi syssi added this to the 0.4.4 milestone Nov 17, 2018
@rytilahti
Copy link
Owner

rytilahti commented Nov 17, 2018

I would say we want to have it both ways, maybe just int_to_rgb and rgb_to_int to do the conversions, and changing set_rgb to take a tuple as input?

@syssi
Copy link
Collaborator Author

syssi commented Nov 17, 2018

Alright. I will care about!

@syssi syssi closed this Nov 17, 2018
@syssi syssi reopened this Nov 17, 2018
@syssi
Copy link
Collaborator Author

syssi commented Nov 18, 2018

@rytilahti I'm done. :-)

@rytilahti
Copy link
Owner

Looking good! 👍

@rytilahti rytilahti merged commit 34c0223 into rytilahti:master Nov 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants