New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix serial number reporting for some devices, add locale command #409

Merged

rytilahti merged 1 commit into master from fix-serial-number

Nov 14, 2018

Owner

rytilahti commented Nov 13, 2018 •

edited

Loading

Fix incorrect serial number handling for some devices as reported in #408:

  File "c:\program files\python\python37\lib\site-packages\python_miio-0.4.10-py3.7.egg\miio\vacuum.py", line 363, in serial_number
    return self.send("get_serial_number")[0]["serial_number"]
TypeError: string indices must be integers

Also adds locale command from #372.


          Fix serial number reporting for some devices, add locale command

ba47efd

coveralls commented Nov 13, 2018

Coverage decreased (-0.1%) to 72.839% when pulling ba47efd on fix-serial-number into a86dc9f on master.

rytilahti merged commit 24f18e8 into master

rytilahti deleted the fix-serial-number branch

November 14, 2018 11:32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet