Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: Add discover method to miiocli #343

Closed
wants to merge 1 commit into from
Closed

RFC: Add discover method to miiocli #343

wants to merge 1 commit into from

Conversation

syssi
Copy link
Collaborator

@syssi syssi commented Jun 18, 2018 •
edited
Loading

No description provided.

houndci-bot
houndci-bot reviewed Jun 18, 2018
View reviewed changes
miio/click_common.py
@@ -210,7 +210,8 @@ def __init__(self, device_class, name=None, invoke_without_command=False,
self.device_class = device_class
self.device_pass = click.make_pass_decorator(device_class)

attrs.setdefault('params', self.DEFAULT_PARAMS)
# FIXME: Must be made optional for the "discover" command
#attrs.setdefault('params', self.DEFAULT_PARAMS)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

block comment should start with '# '

@coveralls
Copy link

coveralls commented Jun 18, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.01%) to 72.426% when pulling f089e4f on syssi:feature/miiocli-discover into fb595be on rytilahti:master.

@syssi syssi mentioned this pull request Jun 20, 2018
Closed
@syssi
Copy link
Collaborator Author

syssi commented Aug 12, 2018

My undestanding of the click usage isn't sufficient to complete this PR unfortunately.

@syssi syssi changed the title WIP: Add discover method to miiocli RFC: Add discover method to miiocli Aug 12, 2018
@yawor
Copy link
Contributor

yawor commented Aug 12, 2018

@syssi on which level do you want the discover method to be? Should it be implemented in each device group (for example miiocli airpurifier discover) or as the top command (miiocli discover)?

The second approach should be easier regarding the --ip and --token params, as they are added by each device group, so they are non existent at the top level. Is there any requirement that the discover should be in the device group?

@rytilahti
Copy link
Owner

@yawor discovery should be done on the global scope, as its main purpose is for users to find to locate (all) available, supported devices. So miiocli discover is what is wanted here :-)

@syssi
Copy link
Collaborator Author

syssi commented Aug 21, 2018

@yawor On global scope cp. #343 (comment)

@rytilahti rytilahti mentioned this pull request Apr 10, 2021
Merged
@rytilahti
Copy link
Owner

Closing this in favor of #1013

@rytilahti rytilahti closed this Apr 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@syssi @coveralls @yawor @rytilahti @houndci-bot