-
-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Device support for the chuangmi plug v1 added #33
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
53f3f8b
Device support for the chuangmi plug v1 strip added.
syssi 4832598
Status class moved.
syssi 76dfd79
Missing import added.
syssi 41a47ae
Merge branch 'master' into feature/plug-v1
syssi 104e766
Merge branch 'master' into feature/plug-v1
rytilahti File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
from .device import Device | ||
from typing import Any, Dict | ||
|
||
|
||
class PlugV1(Device): | ||
"""Main class representing the chuangmi plug v1.""" | ||
|
||
def on(self): | ||
"""Power on.""" | ||
return self.send("set_on", []) | ||
|
||
def off(self): | ||
"""Power off.""" | ||
return self.send("set_off", []) | ||
|
||
def usb_on(self): | ||
"""Power on.""" | ||
return self.send("set_usb_on", []) | ||
|
||
def usb_off(self): | ||
"""Power off.""" | ||
return self.send("set_usb_off", []) | ||
|
||
def status(self): | ||
"""Retrieve properties.""" | ||
properties = ['on', 'usb_on'] | ||
values = self.send( | ||
"get_prop", | ||
properties | ||
) | ||
return PlugV1Status(dict(zip(properties, values))) | ||
|
||
|
||
class PlugV1Status: | ||
"""Container for status reports from the plug.""" | ||
def __init__(self, data: Dict[str, Any]) -> None: | ||
self.data = data | ||
|
||
@property | ||
def power(self) -> bool: | ||
return self.data["on"] | ||
|
||
@property | ||
def is_on(self) -> bool: | ||
return self.power | ||
|
||
@property | ||
def usb_power(self) -> bool: | ||
return self.data["usb_on"] | ||
|
||
def __str__(self) -> str: | ||
s = "<PlugV1Status power=%s, usb_power=%s>" % \ | ||
(self.power, | ||
self.usb_power) | ||
return s |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
undefined name 'Dict'
undefined name 'Any'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An example would also be nice here :-) Are those values already booleans or should they be converted below?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I asked for the response at the same post: https://community.home-assistant.io/t/xiaomi-mi-wifi-plug-air-purifier/16189/99
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, sorry for that, too many PRs got me confused. However, I think we can already merge this after fixing the conflict and update the information when we receive it. Btw, here's someone with the purifier, so at least we can get it tested easily, I hope: https://community.home-assistant.io/t/xiaomi-mi-air-purifier-support/14228/12