Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparation of release 0.3.7 #229

Merged
merged 1 commit into from
Feb 18, 2018

Conversation

syssi
Copy link
Collaborator

@syssi syssi commented Feb 17, 2018

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 67.977% when pulling 9fe50a8 on syssi:feature/release-v0.3.7 into 026cf90 on rytilahti:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 67.977% when pulling 9fe50a8 on syssi:feature/release-v0.3.7 into 026cf90 on rytilahti:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 67.977% when pulling 9fe50a8 on syssi:feature/release-v0.3.7 into 026cf90 on rytilahti:master.

@rytilahti
Copy link
Owner

I'm getting:

construct.core.StreamError: could not write bytes, expected 4, found 8
    (building) -> header -> device_id

with both construct's 2.9.30 and 2.9.31, which are currently the only accepted versions by pinning.

@syssi
Copy link
Collaborator Author

syssi commented Feb 18, 2018

Do you use master? This issue should be fixed already.

@rytilahti
Copy link
Owner

rytilahti commented Feb 18, 2018

I just checked out this PR for testing, looks like device_id is passed in as 'device_id': b'02f2a40d', this isn't right, right?

edit: oops, sorry. I was living in the past master indeed. This is fine, thanks. I'll make a release (tested with the vacuum & the strip).

@rytilahti rytilahti merged commit 3082b61 into rytilahti:master Feb 18, 2018
@rytilahti
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants