Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chuangmi IR command type autodetection #195

Merged
merged 5 commits into from
Jan 29, 2018
Merged

Chuangmi IR command type autodetection #195

merged 5 commits into from
Jan 29, 2018

Conversation

yawor
Copy link
Contributor

@yawor yawor commented Jan 29, 2018

No description provided.

@yawor yawor changed the title Chuangmi IR commant type autodetection Chuangmi IR command type autodetection Jan 29, 2018
@coveralls
Copy link

coveralls commented Jan 29, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.4%) to 67.392% when pulling abcd3b6 on yawor:chuangmi_ir_auto into a50c722 on rytilahti:master.

@syssi
Copy link
Collaborator

syssi commented Jan 29, 2018

Could you implement a few additional tests for:

  • play_pronto('garbage') which raises the Exception
  • play_pronto(PROSONIC_POWER_ON_PRONTO, 0)
  • play('pronto:' + PROSONIC_POWER_ON_PRONTO)
  • play('pronto:' + PROSONIC_POWER_ON_PRONTO + ':0')
  • play('pronto:' + PROSONIC_POWER_ON_PRONTO + ':1')
  • play('raw:' + PROSONIC_POWER_ON)
  • play('raw:' + PROSONIC_POWER_ON + ':19200')
  • play('raw:' + PROSONIC_POWER_ON + ':38400')
  • plray('garbage') which raises the ChuangmiIrException

Many thanks!

@rytilahti rytilahti merged commit e90b7e3 into rytilahti:master Jan 29, 2018
@yawor yawor mentioned this pull request Jan 29, 2018
Merged
7 tasks
@yawor yawor deleted the chuangmi_ir_auto branch January 30, 2018 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syssi syssi syssi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yawor @coveralls @syssi @rytilahti