Fix 'mirobo discover' without --ip and --token #194
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M0ses
force-pushed
the
fix_discovery_without_token
branch
from
a19facb
to
2f94d47
Compare
This patch fixes cli parameter validation for `discover` command:
* by returning a default ip if `None` is passed to `validate_ip`
* by catching the TypeError if `None` is passed to `validate_token`
without this patch I get the following errors
```
...:~/prj/python-miio/miio> mirobo discover --handshake 1
Usage: mirobo [OPTIONS] COMMAND [ARGS]...
Error: Invalid value for "--ip": Invalid IP: None does not appear to be an IPv4 or IPv6 address
```
and
```
...:~/prj/python-miio/miio> mirobo --ip 192.168.8.1 discover --handshake 1
Traceback (most recent call last):
File "/usr/bin/mirobo", line 11, in <module>
load_entry_point('python-miio==0.3.4', 'console_scripts', 'mirobo')()
File "/usr/lib/python3.6/site-packages/miio/click_common.py", line 43, in __call__
return self.main(*args, **kwargs)
File "/usr/lib/python3.6/site-packages/click/core.py", line 696, in main
with self.make_context(prog_name, args, **extra) as ctx:
File "/usr/lib/python3.6/site-packages/click/core.py", line 621, in make_context
self.parse_args(ctx, args)
File "/usr/lib/python3.6/site-packages/click/core.py", line 1018, in parse_args
rest = Command.parse_args(self, ctx, args)
File "/usr/lib/python3.6/site-packages/click/core.py", line 880, in parse_args
value, args = param.handle_parse_result(ctx, opts, args)
File "/usr/lib/python3.6/site-packages/click/core.py", line 1404, in handle_parse_result
self.callback, ctx, self, value)
File "/usr/lib/python3.6/site-packages/click/core.py", line 78, in invoke_param_callback
return callback(ctx, param, value)
File "/usr/lib/python3.6/site-packages/miio/click_common.py", line 28, in validate_token
token_len = len(value)
TypeError: object of type 'NoneType' has no len()
```
M0ses
force-pushed
the
fix_discovery_without_token
branch
from
2f94d47
to
06d133a
Compare
rytilahti
added a commit
that referenced
this pull request
Jan 30, 2018
|
Hi and thanks for the patch (and especially pointing this out, I always had my env variables defined)! I created a patch which feels to me simpler than this one, see #198 . What do you think? |
|
Fixed with #198. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes cli parameter validation for
discovercommand:Noneis passed tovalidate_ipNoneis passed tovalidate_tokenwithout this patch I get the following errors
and