Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All device specific exceptions should derive from DeviceException #179

Merged
merged 1 commit into from
Jan 24, 2018
Merged

All device specific exceptions should derive from DeviceException #179

merged 1 commit into from
Jan 24, 2018

Conversation

syssi
Copy link
Collaborator

@syssi syssi commented Jan 24, 2018

No description provided.

rytilahti
rytilahti approved these changes Jan 24, 2018
View reviewed changes
Copy link
Owner

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@rytilahti rytilahti merged commit 3fdacc8 into rytilahti:master Jan 24, 2018
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 62.541% when pulling 7626673 on syssi:feature/device-exceptions into 744ef07 on rytilahti:master.

1 similar comment
@coveralls
Copy link

coveralls commented Jan 24, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 62.541% when pulling 7626673 on syssi:feature/device-exceptions into 744ef07 on rytilahti:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rytilahti rytilahti rytilahti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@syssi @coveralls @rytilahti