Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make optional deps really optional #1738

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

rytilahti
Copy link
Owner

@rytilahti rytilahti commented Feb 16, 2023

This assigns groups to netifaces and android_backup dependencies so that they shouldn't be required for building the package (e.g. by installing the git checkout using pip). PKGINFO looks like this for them now:

Requires-Dist: android_backup (>=0,<1); extra == "backup_extraction"
Requires-Dist: netifaces (>=0,<1); extra == "updater"

This allows simpler windows builds, related to #1735

This assigns groups to netifaces and android_backup dependencies, so that they are not installed per default.
@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2023

Codecov Report

Merging #1738 (9609b3a) into master (2a33f41) will decrease coverage by 0.01%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #1738      +/-   ##
==========================================
- Coverage   81.93%   81.92%   -0.01%     
==========================================
  Files         196      196              
  Lines       18054    18057       +3     
  Branches     3863     3794      -69     
==========================================
+ Hits        14793    14794       +1     
- Misses       2972     2996      +24     
+ Partials      289      267      -22     
Impacted Files Coverage Δ
miio/device.py 81.21% <0.00%> (-0.81%) ⬇️
miio/devtools/__init__.py 0.00% <0.00%> (ø)
miio/devtools/pcapparser.py 0.00% <0.00%> (ø)
miio/devtools/propertytester.py 0.00% <0.00%> (ø)
miio/devtools/simulators/miiosimulator.py 0.00% <0.00%> (ø)
miio/devtools/simulators/miotsimulator.py 0.00% <0.00%> (ø)
miio/integrations/zimi/clock/alarmclock.py 0.00% <0.00%> (ø)
miio/integrations/roborock/vacuum/vacuum.py 64.83% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rytilahti rytilahti merged commit c8a3f4b into master Feb 16, 2023
@rytilahti rytilahti deleted the fix/make_optional_deps_really_optional branch February 16, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants