Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enum for standardized vacuum identifier names #1732

Merged
merged 5 commits into from
Feb 11, 2023

Conversation

rytilahti
Copy link
Owner

@rytilahti rytilahti commented Feb 10, 2023

This adds an enum of "standardized" identifier names for vacuums to be used by downstreams like homeassistant, and converts viomivacuum integration to use them.

Related to #1729

@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2023

Codecov Report

Merging #1732 (51642bb) into master (313707d) will increase coverage by 0.02%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #1732      +/-   ##
==========================================
+ Coverage   81.91%   81.93%   +0.02%     
==========================================
  Files         195      196       +1     
  Lines       18031    18051      +20     
  Branches     3860     3863       +3     
==========================================
+ Hits        14770    14790      +20     
  Misses       2972     2972              
  Partials      289      289              
Impacted Files Coverage Δ
miio/devicestatus.py 92.03% <100.00%> (+0.36%) ⬆️
miio/identifiers.py 100.00% <100.00%> (ø)
miio/integrations/viomi/viomi/viomivacuum.py 59.55% <100.00%> (+0.18%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rytilahti rytilahti merged commit b4b7f1a into master Feb 11, 2023
@rytilahti rytilahti deleted the feat/add_standard_vacuum_identifiers branch February 11, 2023 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants