Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow defining id for descriptor decorators #1724

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

rytilahti
Copy link
Owner

This is necessary to allow non-miot integrations to use custom naming for their descriptors. It is undecided how the standardized properties and actions are to be exposed to downstreams in the end, but one example would be allowing defining light:brightness for light brightness across the board.

This is necessary to allow non-miot integrations to use custom naming for their descriptors. It is undecided how these are to be exposed to downstreams in the end, but one example would be allowing defining light:brightness for light brightness across the board.
@rytilahti
Copy link
Owner Author

Ping @starkillerOG just that you are in the loop, too :-) This is related to allow defining standardized naming for common actions & properties used by "specialized" homeassistant platforms, e.g., vacuum:start, vacuum:stop (or whatever we decide to call them) where special naming is needed (https://developers.home-assistant.io/docs/core/entity/vacuum/) instead of having a generic button/sensor/binary_sensor.

@rytilahti rytilahti merged commit e4e7c38 into master Feb 9, 2023
@rytilahti rytilahti deleted the feat/descriptor_decos_id_param branch February 9, 2023 01:55
rytilahti added a commit that referenced this pull request Feb 11, 2023
Follow the new standard set in #1724

Co-authored-by: Teemu R. <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant