Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prettier settings and status for genericmiot #1664

Merged
merged 1 commit into from
Jan 14, 2023

Conversation

rytilahti
Copy link
Owner

@rytilahti rytilahti commented Jan 9, 2023

Group status information and settings based on the service for more readable output.
This also adds dumping of extras when -dd is given.
The examples below show the current state using a simulated deerma.humidifier.jsq4.

Status:
image

Status with -dd:
image

Settings:
image

@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2023

Codecov Report

Merging #1664 (407afaf) into master (74577e4) will decrease coverage by 0.03%.
The diff coverage is 11.11%.

@@            Coverage Diff             @@
##           master    #1664      +/-   ##
==========================================
- Coverage   80.29%   80.25%   -0.04%     
==========================================
  Files         161      161              
  Lines       16076    16085       +9     
  Branches     3625     3626       +1     
==========================================
+ Hits        12908    12909       +1     
- Misses       2905     2913       +8     
  Partials      263      263              
Impacted Files Coverage Δ
miio/integrations/genericmiot/genericmiot.py 24.57% <5.88%> (-0.87%) ⬇️
miio/device.py 76.00% <100.00%> (+0.16%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rytilahti rytilahti merged commit d2101bd into master Jan 14, 2023
@rytilahti rytilahti deleted the feat/prettify_settings branch January 14, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants