Handle non-readable miot properties #1662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are (likely) two types of non-readable properties: - Write only properties which can only be set. These are not anymore ignored but descriptors are created also for them. - Properties without access definitions. These are likely used for action input parameter definitions, the earlier warning is converted into a debug message.
Codecov Report
@@ Coverage Diff @@
## master #1662 +/- ##
==========================================
- Coverage 80.37% 80.29% -0.08%
==========================================
Files 161 161
Lines 16047 16076 +29
Branches 3615 3569 -46
==========================================
+ Hits 12897 12908 +11
- Misses 2887 2912 +25
+ Partials 263 256 -7
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adapts the genericmiot to expose also the defined write-only properties and converts the earlier warning to a debug message.
Suppressing the warning is likely fine, as the properties without access defined is now considered to be defined for other reasons (e.g., to define input parameters for actions).