roborock: Fix waterflow setting for Q7 Max+ #1646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1646 +/- ##
==========================================
+ Coverage 80.36% 80.40% +0.04%
==========================================
Files 161 161
Lines 15988 16016 +28
Branches 3607 3612 +5
==========================================
+ Hits 12848 12878 +30
+ Misses 2877 2875 -2
Partials 263 263
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rytilahti
requested changes
Jan 3, 2023
|
Good idea, I've added the tests. |
rytilahti
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has additional Custom setting (207) and
distance_offprovides more fine-grained setting in this case what is not gracefully handled by this PR, as I will create an issue to discuss this.