Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for pet waterer mmgg.pet_waterer.wi11 #1630

Merged
merged 3 commits into from
Jan 1, 2023

Conversation

Alex-ala
Copy link
Contributor

The pet waterer mmgg.pet_waterer.wi11 has the "fault" and "on" ids switched.
https://home.miot-spec.com/spec?type=urn:miot-spec-v2:device:pet-drinking-fountain:0000A067:mmgg-wi11:1

The petwaterdispenser device was updated to support all 3 versions of water dispensers.

@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2022

Codecov Report

Merging #1630 (f4bb08d) into master (cdca98f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1630   +/-   ##
=======================================
  Coverage   80.26%   80.27%           
=======================================
  Files         161      161           
  Lines       15907    15911    +4     
  Branches     3577     3577           
=======================================
+ Hits        12768    12772    +4     
  Misses       2876     2876           
  Partials      263      263           
Impacted Files Coverage Δ
miio/integrations/petwaterdispenser/device.py 70.68% <100.00%> (+2.17%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Owner

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR @Alex-ala! 👍

@rytilahti rytilahti merged commit aa2122b into rytilahti:master Jan 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants