Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add range_attribute parameter to NumberSettingDescriptor #1602

Merged
merged 4 commits into from
Nov 23, 2022

Conversation

rytilahti
Copy link
Owner

Allows defining a property to use for obtaining the valid range for a setting that can be used for model-specific ranges (e.g., for color temperatures and fan angles).

This also converts yeelight and LightInterface to use it.

@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2022

Codecov Report

Merging #1602 (d926b60) into master (086bc8c) will decrease coverage by 0.12%.
The diff coverage is 42.55%.

@@            Coverage Diff             @@
##           master    #1602      +/-   ##
==========================================
- Coverage   80.88%   80.76%   -0.13%     
==========================================
  Files         157      157              
  Lines       15338    15346       +8     
  Branches     3350     3350              
==========================================
- Hits        12406    12394      -12     
- Misses       2676     2700      +24     
+ Partials      256      252       -4     
Impacted Files Coverage Δ
miio/integrations/light/yeelight/yeelight.py 79.60% <28.94%> (-7.85%) ⬇️
miio/descriptors.py 96.42% <100.00%> (+0.42%) ⬆️
miio/devicestatus.py 91.35% <100.00%> (ø)
miio/interfaces/lightinterface.py 93.75% <100.00%> (+0.41%) ⬆️
miio/integrations/vacuum/roborock/vacuum_enums.py 100.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rytilahti rytilahti merged commit 3ea3e2c into master Nov 23, 2022
@rytilahti rytilahti deleted the feat/descriptor_range_from_attribute branch November 23, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants