-
-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional sensors and settings to Roborock vacuums #1585
Conversation
@rytilahti can you have a look an merge this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of comments, but all in all this looks good 👍
@rytilahti could you test again/merge? |
@rytilahti I think this can be merged right? |
How about the concern regarding removing the entity_category for the time being? We can discuss that later after we have a better view of how that's going to work with the genericmiot |
I made a PR to your HomeAssistant fork here: rytilahti/home-assistant#4 |
We can not just set a default since for instance the Battery schould not have a entity category (schould not be diagnostic but a sensor), so we schould somehow properly implement this. I would rather keep it in this PR, because I now figured out which ones schould have which catogory, otherwise I need to figure it out again later. |
@rytilahti could you agree to that? |
I'm fine with that, thank you @starkillerOG :-) Prior merging this, would you please adjust the PR description to be a bit more descriptive about the changes introduced in this PR for anyone reading the git logs in the future? |
@rytilahti I updated the PR description, can you merge? |
Split out from #1543
Add additional sensors and improve the already implemented sensors for the Roborock S7 MaxV.
Split vacuum enums to a separte file to prevent circular imports
Controls added: