Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add zhimi.airpurifier.amp1 support #1464

Merged
merged 2 commits into from
Jul 17, 2022
Merged

Conversation

dsh0416
Copy link
Contributor

@dsh0416 dsh0416 commented Jul 17, 2022

No description provided.

@dsh0416 dsh0416 changed the title add rma1 support add zhimi.airpurifier.amp1 support Jul 17, 2022
Copy link
Owner

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can be merged after the checks pass. Thanks @dsh0416!

@rytilahti rytilahti added this to the 0.5.12 milestone Jul 17, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2022

Codecov Report

Merging #1464 (174e059) into master (32d41ce) will decrease coverage by 0.31%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1464      +/-   ##
==========================================
- Coverage   82.80%   82.48%   -0.32%     
==========================================
  Files         140      140              
  Lines       13813    13898      +85     
  Branches     1553     3304    +1751     
==========================================
+ Hits        11438    11464      +26     
- Misses       2156     2214      +58     
- Partials      219      220       +1     
Impacted Files Coverage Δ
...integrations/airpurifier/zhimi/airpurifier_miot.py 80.82% <100.00%> (+0.08%) ⬆️
miio/gateway/alarm.py 47.72% <0.00%> (-7.83%) ⬇️
miio/gateway/devices/subdevice.py 33.14% <0.00%> (-3.74%) ⬇️
miio/gateway/gateway.py 44.44% <0.00%> (-1.76%) ⬇️
miio/push_server/server.py 24.62% <0.00%> (+1.14%) ⬆️
miio/gateway/gatewaydevice.py 69.23% <0.00%> (+2.56%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@rytilahti rytilahti merged commit dacccb3 into rytilahti:master Jul 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants