Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fan speed presets to VacuumInterface #1405

Merged
merged 36 commits into from
May 23, 2022
Merged

Add fan speed presets to VacuumInterface #1405

merged 36 commits into from
May 23, 2022

Conversation

2pirko
Copy link
Contributor

@2pirko 2pirko commented Apr 25, 2022

No description provided.

2pirko and others added 24 commits March 13, 2022 10:48
@2pirko
Added Xiaomi Vaccum Mop 2 Ultra and Pro+
4e63252
@2pirko
Updated automatic formatting using black
6e8f278
@2pirko
Removed duplicated supported models
e21387c
@2pirko
Extended dreame test to test all supported models
469cc89
@2pirko
Added test for invalid dreame model
2db536c
@2pirko
Formatting by black
05a6ea1
@2pirko
import isort
2db26f4
@2pirko
Updated readme with newly supported models
7723bfa
@2pirko
Added support for Vacuum interface: VaccumDevice and VacuumMiotDevice
2dd5e61
@2pirko
Merge branch 'master' into vaccum_device
c354dd4
@2pirko
Fixed isort
dc1ccfa
@2pirko
Removing unnecessary pass
5ba5374
@2pirko
Feedback from PR: VaccumDevice renamed to VacuumInterface
866e856
@2pirko
Step2: VacuumInterface no moreinherits Device
4f7c5da
@2pirko
Unit test fixed
c25552f
@2pirko
Merge branch 'master' into vaccum_device
4910920
@2pirko
Merge branch 'master' into vaccum_device
4ce7c75
@2pirko
Merge branch 'master' into vaccum_device
c5ad8c8
@2pirko
VaccumInterface published as symbol available for the "interface" pac…
1ac8138 
…kage
@2pirko
Merge branch 'master' into vaccum_device
01406ea
@2pirko
Added two methods into VacuumInterface:
af8fffb 
- fan_speed_presets()
- set_fan_speed_preset(speed)
@2pirko
Added vacuum unit test
580b94f
@2pirko
Merge branch 'master' into vacuum_interface_fan_speed_presets
ccad8fb 
# Conflicts:
#	miio/interfaces/vacuuminterface.py
@2pirko
Fixed python 3.10
a3a8ee0
@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2022 •
edited
Loading

Codecov Report

Merging #1405 (372702a) into master (31c5d74) will increase coverage by 0.13%.
The diff coverage is 89.47%.

@@            Coverage Diff             @@
##           master    #1405      +/-   ##
==========================================
+ Coverage   84.18%   84.31%   +0.13%     
==========================================
  Files         135      135              
  Lines       13348    13389      +41     
  Branches     1485     1493       +8     
==========================================
+ Hits        11237    11289      +52     
+ Misses       1900     1883      -17     
- Partials      211      217       +6
Impacted Files Coverage Δ
miio/integrations/vacuum/roborock/vacuum.py 65.28% <75.00%> (+2.04%) ⬆️
miio/integrations/vacuum/mijia/g1vacuum.py 74.35% <77.77%> (+0.03%) ⬆️
miio/integrations/vacuum/viomi/viomivacuum.py 58.17% <77.77%> (+0.29%) ⬆️
...io/integrations/vacuum/dreame/dreamevacuum_miot.py 78.73% <100.00%> (+2.38%) ⬆️
...ions/vacuum/dreame/tests/test_dreamevacuum_miot.py 100.00% <100.00%> (ø)
...io/integrations/vacuum/roidmi/roidmivacuum_miot.py 89.73% <100.00%> (+0.24%) ⬆️
...ions/vacuum/roidmi/tests/test_roidmivacuum_miot.py 100.00% <100.00%> (ø)
miio/interfaces/__init__.py 100.00% <100.00%> (ø)
miio/interfaces/vacuuminterface.py 93.75% <100.00%> (+3.75%) ⬆️
... and 1 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@2pirko 2pirko changed the title Vacuum interface fan speed presets2 Vacuum interface fan speed presets Apr 25, 2022
@2pirko
Copy link
Contributor Author

2pirko commented Apr 25, 2022

@rytilahti , VacuumInterface update ready to merge !

rytilahti
rytilahti reviewed Apr 25, 2022
View reviewed changes
miio/integrations/vacuum/mijia/g1vacuum.py Outdated Show resolved Hide resolved
miio/integrations/vacuum/mijia/g1vacuum.py Outdated Show resolved Hide resolved
miio/interfaces/vacuuminterface.py Outdated Show resolved Hide resolved
miio/tests/test_vacuums.py Outdated Show resolved Hide resolved
miio/tests/test_vacuums.py Outdated Show resolved Hide resolved
miio/tests/test_vacuums.py Outdated Show resolved Hide resolved
miio/tests/test_vacuums.py Show resolved Hide resolved
@2pirko
Copy link
Contributor Author

2pirko commented Apr 26, 2022

@rytilahti , ready to merge!

rytilahti
rytilahti reviewed Apr 27, 2022
View reviewed changes
miio/interfaces/vacuuminterface.py Outdated Show resolved Hide resolved
miio/integrations/vacuum/mijia/g1vacuum.py Outdated Show resolved Hide resolved
miio/integrations/vacuum/mijia/g1vacuum.py Outdated Show resolved Hide resolved
miio/integrations/vacuum/mijia/g1vacuum.py Outdated Show resolved Hide resolved
docs/conf.py Outdated Show resolved Hide resolved
miio/tests/test_vacuums.py Show resolved Hide resolved
miio/tests/test_vacuums.py Show resolved Hide resolved
miio/integrations/vacuum/mijia/g1vacuum.py Outdated Show resolved Hide resolved
rytilahti
rytilahti approved these changes Apr 30, 2022
View reviewed changes
Copy link
Owner

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to go as soon as the conflict is fixed 👍

@2pirko
Copy link
Contributor Author

2pirko commented May 2, 2022

@rytilahti , it seems there is a new problem reported in code, which is not mine. Probably new pylint/flake8?

@rytilahti
Copy link
Owner

Looks like that https://github.com/JBKahn/flake8-print suddenly changed the error code from T001 to T201 in those files. Feel free to change those noqa entries as indicated by the flake8 run.

@2pirko
Copy link
Contributor Author

2pirko commented May 2, 2022

@rytilahti , merge now?

@2pirko
Copy link
Contributor Author

2pirko commented May 14, 2022 •
edited
Loading

@rytilahti , I'm done with this pull request, you can merge it

1 similar comment
@2pirko
Copy link
Contributor Author

2pirko commented May 20, 2022

@rytilahti , I'm done with this pull request, you can merge it

@2pirko
Copy link
Contributor Author

2pirko commented May 22, 2022

@rytilahti , you can merge this pull request OR delete it.

@rytilahti rytilahti changed the title Vacuum interface fan speed presets Add fan speed presets to VacuumInterface May 23, 2022
@rytilahti
Copy link
Owner

I updated the docstrings & tidied the PR a bit, I'll merge as soon as the tests pass. Thanks @2pirko!

@rytilahti rytilahti merged commit a1def97 into rytilahti:master May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rytilahti rytilahti rytilahti approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@2pirko @codecov-commenter @rytilahti