-
-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for zhimi.heater.za2 #1301
Conversation
Hi and thanks for the PR! Instead of creating a separate class that would necessitate separate tests etc., please just extend the existing implementation as they are from the same manufacturer and they do not differ that much. You can do that by basing your PR on top of #1302, and introducing For the extra
|
On za2, |
@rytilahti This should work now. But as I modified the class |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two more things and this is good to go!
Btw, you can run the linting tests also locally by executing pre-commit run -a
or tox -e lint
, this way you can fix them without waiting for me to approve the run on CI.
I've run the tests and it shall be fine now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the tests and update README.md, and then this is good to go! 🎉
Oh, looks like the tests are still failing. Btw, you can also run the tests locally by executing |
The reason why the tests are not passed is that the dummy test cases are based on mc2, but I chose to fall back on the strictest restriction in times of unrecognized models, including dummy. |
Codecov Report
@@ Coverage Diff @@
## master #1301 +/- ##
==========================================
- Coverage 82.34% 82.30% -0.05%
==========================================
Files 106 106
Lines 11404 11417 +13
Branches 1354 1357 +3
==========================================
+ Hits 9391 9397 +6
- Misses 1821 1825 +4
- Partials 192 195 +3
Continue to review full report at Codecov.
|
This is good to go, thanks @PRO-2684! |
This release adds support for several new devices (see details below, thanks to @PRO-2684, @peleccom, @ymj0424, and @supar), and contains improvements to Roborock S7, yeelight and gateway integrations (thanks to @starkillerOG, @Kirmas,> Python 3.6 is no longer supported, and Fan{V2,SA1,ZA1,ZA3,ZA4} utility classes are now removed in favor of using Fan class. [Full Changelog](0.5.9.2...0.5.10) **Breaking changes:** - Split fan.py to vendor-specific fan integrations [\#1304](#1304) (@rytilahti) - Drop python 3.6 support [\#1263](#1263) (@rytilahti) **Implemented enhancements:** - Improve miotdevice mappings handling [\#1302](#1302) (@rytilahti) - airpurifier\_miot: force aqi update prior fetching data [\#1282](#1282) (@rytilahti) - improve gateway error messages [\#1261](#1261) (@starkillerOG) - yeelight: use and expose the color temp range from specs [\#1247](#1247) (@Kirmas) - Add Roborock S7 mop scrub intensity [\#1236](#1236) (@shred86) **New devices:** - Add support for zhimi.heater.za2 [\#1301](#1301) (@PRO-2684) - Dreame F9 Vacuum \(dreame.vacuum.p2008\) support [\#1290](#1290) (@peleccom) - Add support for Air Purifier 4 Pro \(zhimi.airp.va2\) [\#1287](#1287) (@ymj0424) - Add support for deerma.humidifier.jsq{s,5} [\#1193](#1193) (@supar) **Merged pull requests:** - Add roborock.vacuum.a23 to supported models [\#1314](#1314) (@rytilahti) - Move philips light implementations to integrations/light/philips [\#1306](#1306) (@rytilahti) - Move leshow fan implementation to integrations/fan/leshow/ [\#1305](#1305) (@rytilahti) - Split fan\_miot.py to vendor-specific fan integrations [\#1303](#1303) (@rytilahti) - Add chuangmi.remote.v2 to chuangmiir [\#1299](#1299) (@rytilahti) - Perform pypi release on github release [\#1298](#1298) (@rytilahti) - Print debug recv contents prior accessing its contents [\#1293](#1293) (@rytilahti) - Add more supported models [\#1292](#1292) (@rytilahti) - Add more supported models [\#1275](#1275) (@rytilahti) - Update installation instructions to use poetry [\#1259](#1259) (@rytilahti) - Add more supported models based on discovery.py's mdns records [\#1258](#1258) (@rytilahti)
This release adds support for several new devices (see details below, thanks to @PRO-2684, @peleccom, @ymj0424, and @supar), and contains improvements to Roborock S7, yeelight and gateway integrations (thanks to @starkillerOG, @Kirmas, and @shred86). Thanks also to everyone who has reported their working model information, we can use this information to provide better discovery in the future and this release silences the warning for known working models. Python 3.6 is no longer supported, and Fan{V2,SA1,ZA1,ZA3,ZA4} utility classes are now removed in favor of using Fan class. [Full Changelog](0.5.9.2...0.5.10) **Breaking changes:** - Split fan.py to vendor-specific fan integrations [\#1304](#1304) (@rytilahti) - Drop python 3.6 support [\#1263](#1263) (@rytilahti) **Implemented enhancements:** - Improve miotdevice mappings handling [\#1302](#1302) (@rytilahti) - airpurifier\_miot: force aqi update prior fetching data [\#1282](#1282) (@rytilahti) - improve gateway error messages [\#1261](#1261) (@starkillerOG) - yeelight: use and expose the color temp range from specs [\#1247](#1247) (@Kirmas) - Add Roborock S7 mop scrub intensity [\#1236](#1236) (@shred86) **New devices:** - Add support for zhimi.heater.za2 [\#1301](#1301) (@PRO-2684) - Dreame F9 Vacuum \(dreame.vacuum.p2008\) support [\#1290](#1290) (@peleccom) - Add support for Air Purifier 4 Pro \(zhimi.airp.va2\) [\#1287](#1287) (@ymj0424) - Add support for deerma.humidifier.jsq{s,5} [\#1193](#1193) (@supar) **Merged pull requests:** - Add roborock.vacuum.a23 to supported models [\#1314](#1314) (@rytilahti) - Move philips light implementations to integrations/light/philips [\#1306](#1306) (@rytilahti) - Move leshow fan implementation to integrations/fan/leshow/ [\#1305](#1305) (@rytilahti) - Split fan\_miot.py to vendor-specific fan integrations [\#1303](#1303) (@rytilahti) - Add chuangmi.remote.v2 to chuangmiir [\#1299](#1299) (@rytilahti) - Perform pypi release on github release [\#1298](#1298) (@rytilahti) - Print debug recv contents prior accessing its contents [\#1293](#1293) (@rytilahti) - Add more supported models [\#1292](#1292) (@rytilahti) - Add more supported models [\#1275](#1275) (@rytilahti) - Update installation instructions to use poetry [\#1259](#1259) (@rytilahti) - Add more supported models based on discovery.py's mdns records [\#1258](#1258) (@rytilahti)
This PR adds support to zhimi.heater.za2.
heater_miot_za2.py
's code is modified fromheater_miot.py
. Compared to already supported mc2 model, za2 can monitor relative humidity, so I addedrelative_humidity
function.P.S. Comment is wrong at
heater_miot.py
, line 21. Should be# Physical Control Locked (siid=5)
.