Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error on GATEWAY_MODEL_ZIG3 when no zigbee devices connected #1065

Merged
merged 3 commits into from
Jun 4, 2021

Conversation

starkillerOG
Copy link
Contributor

fix error on GATEWAY_MODEL_ZIG3 when no zigbee devices connected
see issue: home-assistant/core#51294

Copy link
Owner

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and simple, can be merged when the lint checks pass!

@codecov-commenter
Copy link

codecov-commenter commented Jun 4, 2021

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 75.40%. Comparing base (6453bfe) to head (0c9b0c2).
Report is 384 commits behind head on master.

Files Patch % Lines
miio/gateway/gateway.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1065      +/-   ##
==========================================
- Coverage   75.42%   75.40%   -0.03%     
==========================================
  Files          73       73              
  Lines        8359     8367       +8     
  Branches      744      745       +1     
==========================================
+ Hits         6305     6309       +4     
- Misses       1870     1874       +4     
  Partials      184      184              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@starkillerOG
Copy link
Contributor Author

@rytilahti this is ready to be merged.

@rytilahti rytilahti merged commit 6ab4665 into rytilahti:master Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants