Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github flow for ci #1044

Merged
merged 4 commits into from
May 17, 2021
Merged

Conversation

rytilahti
Copy link
Owner

@rytilahti rytilahti commented May 11, 2021

This PR converts away from azure pipelines to github actions which simplifies the setup & make coverage working again.

When that works, it will be much simpler to add a workflow for doing releases (incl. changelog generation, tagging, and publishing to pypi), hopefully. The aim is to make it releasing not a chore.

@codecov-commenter
Copy link

codecov-commenter commented May 11, 2021

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@46f9b84). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1044   +/-   ##
=========================================
  Coverage          ?   75.22%           
=========================================
  Files             ?       73           
  Lines             ?     8203           
  Branches          ?      726           
=========================================
  Hits              ?     6171           
  Misses            ?     1857           
  Partials          ?      175           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rytilahti
Copy link
Owner Author

This got stuck waiting for the pipeline checks that were not anymore part of it, even after removing those specific checks from the branch protection requirements. Removing the branch protection temporarily fixed this :-)

@rytilahti rytilahti merged commit f3f9550 into master May 17, 2021
@rytilahti rytilahti deleted the janitor/migrate_to_github_workflows branch May 17, 2021 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants