Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: cleanup() takes 1 positional argument but 2 were given #386

Closed
giejay opened this issue Oct 6, 2018 · 2 comments
Closed

TypeError: cleanup() takes 1 positional argument but 2 were given #386

giejay opened this issue Oct 6, 2018 · 2 comments

Comments

@giejay
Copy link

giejay commented Oct 6, 2018

Hi,

I've got my robot (v1) working fine but every time I execute a command, which does work, its followed by an error.

For example:
mirobo zoned-clean [coordinates]
Cleaning zone(s) : ['ok']
Traceback (most recent call last):
File "/usr/local/bin/mirobo", line 11, in
sys.exit(cli())
File "/usr/local/lib/python3.5/dist-packages/miio/click_common.py", line 54, in call
return self.main(*args, **kwargs)
File "/usr/local/lib/python3.5/dist-packages/click/core.py", line 717, in main
rv = self.invoke(ctx)
File "/usr/local/lib/python3.5/dist-packages/click/core.py", line 1137, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/usr/local/lib/python3.5/dist-packages/click/core.py", line 1102, in _process_result
**ctx.params)
File "/usr/local/lib/python3.5/dist-packages/click/core.py", line 555, in invoke
return callback(*args, **kwargs)
File "/usr/local/lib/python3.5/dist-packages/click/decorators.py", line 64, in new_func
return ctx.invoke(f, obj, *args, **kwargs)
File "/usr/local/lib/python3.5/dist-packages/click/core.py", line 555, in invoke
return callback(*args, **kwargs)
TypeError: cleanup() takes 1 positional argument but 2 were given

Do I need to upgrade my Python (3.5) or something?

@rytilahti
Copy link
Owner

rytilahti commented Oct 6, 2018

Looks like here's a similar issue: rytilahti/python-eq3bt#26 -- This seems to be a breaking change in click (with click==6.7 it works just fine). I'll look into it fixing it, in the meanwhile you can downgrade your click version.

@giejay
Copy link
Author

giejay commented Oct 6, 2018

Thanks for the fast response, pip3 uninstall Click and pip3 install Click==6.7 did the trick!

rytilahti added a commit that referenced this issue Oct 6, 2018
click7 changed the passed parameters for a resultcallback,
this commit simply adds unused *args to the method signature to make
it work on both click6.7 and click7.

Fixes #386
rytilahti added a commit that referenced this issue Oct 6, 2018
click7 changed the passed parameters for a resultcallback,
this commit simply adds unused *args to the method signature to make
it work on both click6.7 and click7.

Fixes #386
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants