-
-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No working with Xiaowa (roborock.vacuum.c1 v1.3.0) #370
Comments
@rytilahti I don't have experience in Python coding unfortunately, |
For the first one, maybe this vacuum uses the same scheme as seen in #364? You could try For the second one you should try the command with (btw, when you use triple-backticks it will format multi-line code properly, I edited the initial message accordingly) |
Hi @rytilahti . Enabling debug mode added the following to the install_sound command output:
The rest is the same traceback ending by 'No request was made..' as in my earlier message. |
The API has changed for Anyway, the PR I linked should fix the basic functionality, it would be nice if you could give it a try and report back:
|
Hi, @rytilahti
So I modified it to (that I am not sure if it is correct) |
P.S. Most likely I didn't pick up the latest update as when I try to use new commands you added in your merge request (locale, firmware_features) it says 'No such command'. |
Yes, apparently it didn't work as expected. You could try to remove the existing source directory and try it again. Or check out https://help.github.com/articles/checking-out-pull-requests-locally/ and/or https://stackoverflow.com/questions/27567846/how-can-i-check-out-a-github-pull-request . |
I cloned code from 'vacuum_gen2' branch to local folder and (after cleaning local packages) installed python-miio from there. |
It should not matter as setup.py is only used for version checking, so you have to either force the install or use |
It looks like I have correct mirobo version as |
Is it sending out the correct command? If you add |
Hi @rytilahti
Raw response is as follows
|
@andrei-khveras I think I found the problem (thanks to @Luc3as). I created a PR #408 (and cherry-picked that to |
@rytilahti this is a great news. |
* Force parameters to be an empty list if none is given This seems to work fine with yeelight and gen1 vacuum, however, more testing is needed with other devices and/or this change should only be done for the vacuum. Related to #348 / Xiaowa E352 * Remove empty lists to use the new default Fixes #348, #364 and #370.
This should now work in master (fixed by #408, no clue why this wasn't closed automatically). |
Hi @rytilahti I picked up the latest changes from master with command
and tried to execute While
Could you advise, maybe I am doing something not in right way? |
It is returning |
Hi @rytilahti |
Cleaner: roborock.vacuum.c1 v1.3.0
Ubuntu 18, python 3.6
After successful
mirobo discover --handshake true
Getting
Error: {'code': -32600, 'message': 'Req object invalid.'}
when executing
mirobo --ip=XXX --token=YYY status
When executing
mirobo --ip=XXX --token=YYY install_sound ru_maxim_universal.pkg
getting
The text was updated successfully, but these errors were encountered: