construct-code uptodate #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Feb 16, 2018
| "target_temp" / TempAdapter(Int8ub), | ||
| "away" / IfThenElse(lambda ctx: ctx.mode.AWAY, | ||
| AwayDataAdapter(Byte[4]), | ||
| GreedyBytes), |
There was a problem hiding this comment.
continuation line under-indented for visual indent
| Const(0x04, Int8ub), | ||
| "target_temp" / TempAdapter(Int8ub), | ||
| "away" / IfThenElse(lambda ctx: ctx.mode.AWAY, | ||
| AwayDataAdapter(Byte[4]), |
There was a problem hiding this comment.
continuation line under-indented for visual indent
| "valve" / Int8ub, | ||
| Const(0x04, Int8ub), | ||
| "target_temp" / TempAdapter(Int8ub), | ||
| "away" / IfThenElse(lambda ctx: ctx.mode.AWAY, |
| return int(obj * 2.0) | ||
|
|
||
| ModeFlags = "ModeFlags" / FlagsEnum(Int8ub, | ||
| AUTO=0x00, | ||
| AUTO=0x00, # always True, doesnt affect building |
There was a problem hiding this comment.
at least two spaces before inline comment
line too long (84 > 79 characters)
mrlexley
approved these changes
Feb 16, 2018
|
There is no version ".3" |
|
Typo mean .30 |
|
Seems to work fine with 2.9.32. I'll ignore the hound warnings this time and prepare a make a new release, thanks for the patch! |
|
For the record, Timestamp class was added but even tho it supports custom epochs and units, and even ancient MSDOS format, it would not support a custom bitstruct. So stick to the custom adapter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings construct-related code uptodate, but it requires 2.9.31 which will be shipped within a day.
https://pypi.org/project/construct/
There is FlagsEnum thingy: value 0 doesnt make much sense, because parsing always sets it True and building is not affected by that flag regardless if its set. Its correct code, but not proper.