Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement fixes #314

Merged
merged 23 commits into from
Feb 7, 2023
Merged

feat: implement fixes #314

merged 23 commits into from
Feb 7, 2023

Conversation

kjr217
Copy link
Contributor

@kjr217 kjr217 commented Jan 3, 2023

Task:

Description

Fix a bug on gmx reactor

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Document update
  • Quality of life improvement

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have NATSPEC'd any new functions
  • If appropriate, I have properly tested my new functionality

bestatigen and others added 9 commits November 10, 2022 18:25
Remove 11am UTCs
* fixed walletconnect

* Use react-app-rewired to include buffer

- Remove require from App.tsc

* Move react-app-rewired to dev dependencies

Co-authored-by: Yassine <[email protected]>
Use correct chain hex id for Arbitrum
* fix: parseFloat growthSinceFirstEpoch

* docs: Comment about parseFloat of BigDecimal string
fix(charts): Use Array to build PPS graph data

Using the map return doesn't guarantee order
* style(trades): Refresh style of Table

* style(trades): Minor adjustments

align amount right
restyle trade tab column
use normal font for first
column

* build(packages): Add react-fullscreen

* feat(components): Fullscreen trades

* feat(hooks): useElementOnScreen.tsx

Hook that allows to check if an element is on screen or not.

* feat(app): Merge policies for paged query

For writeOptions, buybackOption and rebalanceDelta simply add incoming
to the end of array

* feat(components): 10 days paging for trades

Retrieve last 10 days of trades on scroll, 10 by 10

* fix(components): fetch more if trades on screen

In case last trade is still intersecting with viewport this triggers
fetch more anyway as we move the ref to the last trade on render

* build(package): react-content-loader

* feat(components): Loaders for table

* style(components): bg color of loaders

* fix(components): bg of last td while fullscreen
fix(graph): Order pricePerShares by timestamp
* fix(components): Fix svg card tabs to fit

otherwise the tab stays smaller than the text in it

* refactor(components): Hide progress bar if no collateral

better ui

* style(components): Move home banner closer to top

better ui

* refactor(components): Show query error in trades table if any

+ add bg-bone to fullscreen component

* fix(graph): Skip query if !account in dashboard options

otherwise it retrieves all of Graphs option as empty string is passed

Closes #309

* fix(components): Allow any user to see orders

already working for strangle but not single put or call order

Closes #311
bestatigen and others added 11 commits January 6, 2023 10:53
* Move to Goerli (from Rinkeby)

* Remove Rinkeby contracts

* Update Explorer to Goerli for Testnet

* Add deployed Opyn Gamma Goerli Subgraph

* refactor: alpha sort constants
* Add eslint rule to remove unnecessary imports on React.

* Clean up unused component.

* Set baseUrl to allow cleaner imports.

* Package additions for handling dates and animations.

* Vault performance chart adjustments and readme.

* Clean up after moving file location.

* More readable text length.
… Use REACT_APP_NETWORK over REACT_APP_ENV to determine network to use.
Noindex, Nofollow for all deployments except prod
* Upgrade to React 18.2.0 and fix typing issues.

* Fix react imports and typing issues.
Bumps [npm](https://github.com/npm/cli) from 8.9.0 to 8.11.0.
- [Release notes](https://github.com/npm/cli/releases)
- [Changelog](https://github.com/npm/cli/blob/v8.11.0/CHANGELOG.md)
- [Commits](npm/cli@v8.9.0...v8.11.0)

---
updated-dependencies:
- dependency-name: npm
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
* Clean up package.json files for better consistency.

* Move to Yarn and Yarn workspaces.

* Build without bash script.

* Fix syntax errors.

* Remove non-existent files.

* Workspaces with nohoist for typechain packages.

* Update docs.

* Lock updates.

* Remove console.logs and fix bad test.
@kjr217 kjr217 merged commit 9040eb3 into gmx-reactor Feb 7, 2023
@kjr217 kjr217 deleted the fix/gmx-reactor-fail branch February 7, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants