-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature - Performance Table with Price per Share #282
Merged
ugolino
merged 11 commits into
rysk-alpha
from
feature-performance-table-price-per-share
Oct 26, 2022
Merged
Changes from 3 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
e1e9ef6
Show growthSinceFirstEpoch as Cumulative Yield
bestatigen 6726de0
Fill PricePerShares Performance Chart
bestatigen 9c46f59
Comment
bestatigen 784d1d5
Copy
bestatigen a29995e
Get first 1000 pricePerShares
bestatigen 0611adf
chart labels
ugolino 0048566
Group PricePerShare Epochs by Day
bestatigen 3dcc698
Minor adjustments to Performance plot
bestatigen 0b3b675
Minor adjustments to Performance plot
bestatigen 60b00fd
Set Performance Plot line to natural
bestatigen 94366e7
Revert group by day
bestatigen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the ratio for the first 30 only?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought to keep it for the last 30 epochs only, and eventually retrieve the others using graph's paging and adding toggle for users to pick different amount of epochs (30, 100, 1000)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok got it. maybe for now we go for higher and then we implement toggle in future releases