Fix issue with Yield timestamp order (#299)

fix(charts): Use Array to build PPS graph data Using the map return doesn't guarantee order
rysk-finance · Dec 2, 2022 · 0439e00 · 0439e00
1 parent 3ae8d1d
commit 0439e00
Showing 1 changed file with 22 additions and 22 deletions.
diff --git a/packages/front-end/src/components/VaultChart.tsx b/packages/front-end/src/components/VaultChart.tsx
@@ -68,30 +68,30 @@ export const VaultChart = () => {
     `,
     {
       onCompleted: (data) => {
-        const refinedData: any = data?.pricePerShares
-          ? data.pricePerShares.map((ppsEpoch: any) => {
-              const dateLocale = new Date(
-                parseInt(ppsEpoch.timestamp) * 1000
-              ).toLocaleString("default", {
-                month: "numeric",
-                day: "numeric",
-                year: "numeric",
-              });
+        const refinedData: any =
+          data?.pricePerShares?.length > 0
+            ? new Array(data.pricePerShares.length)
+            : [];
 
-              return {
-                epoch: ppsEpoch.id,
-                // @reminder: For presentation it's ok but reminder that number of float decimals is 17
-                growthSinceFirstEpoch: parseFloat(
-                  ppsEpoch.growthSinceFirstEpoch
-                ),
-                timestamp: ppsEpoch.timestamp,
-                dateLocale,
-              };
-            })
-          : [];
+        data.pricePerShares.map((ppsEpoch: any) => {
+          const dateLocale = new Date(
+            parseInt(ppsEpoch.timestamp) * 1000
+          ).toLocaleString("default", {
+            month: "numeric",
+            day: "numeric",
+            year: "numeric",
+          });
 
-        Object.keys(refinedData).length > 0 &&
-          setPricePerShares(Object.values(refinedData));
+          refinedData[+ppsEpoch.id - 1] = {
+            epoch: ppsEpoch.id,
+            // @reminder: For presentation it's ok but reminder that number of float decimals is 17
+            growthSinceFirstEpoch: parseFloat(ppsEpoch.growthSinceFirstEpoch),
+            timestamp: ppsEpoch.timestamp,
+            dateLocale,
+          };
+        });
+
+        setPricePerShares(refinedData);
       },
       onError: (err) => {
         console.log(err);