refactor(svelte): Use jiti for dynamic imports of svelte/compiler
#203
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
Warning Rate limit exceeded@ryoppippi has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 25 minutes and 21 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThe main change introduced involves the inclusion of the Changes
Sequence Diagram(s)sequenceDiagram
participant Code as Code
participant Jiti as Jiti
participant SvelteCompiler as Svelte Compiler
Code->>Jiti: createJiti(import.meta.url)
Code->>SvelteCompiler: jiti.import('svelte/compiler')
SvelteCompiler-->>Code: { preprocess: sveltePreprocess }
Assessment against linked issues
PoemThank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
bun.lockbis excluded by!**/bun.lockb
Files selected for processing (2)
- packages/unplugin-typia/package.json (1 hunks)
- packages/unplugin-typia/src/core/languages/svelte.ts (2 hunks)
Files skipped from review due to trivial changes (1)
- packages/unplugin-typia/package.json
Additional comments not posted (2)
packages/unplugin-typia/src/core/languages/svelte.ts (2)
1-6: LGTM! Import and initialization ofjitiare correct.The import statement for
createJitifrom thejitipackage and the initialization ofjitiusingimport.meta.urlare correctly implemented.
29-29: LGTM! Dynamic import usingjitiis correctly implemented.The dynamic import using
jitiin thepreprocessfunction correctly replaces the static import ofsvelte/compiler.
…m to local import.... This commit introduces 'jiti' for handling dynamic imports in the svelte compiler. This change is reflected in the 'svelte.ts' file where 'jiti' is imported and used for importing the svelte compiler. The 'jiti' package is also added to the package.json dependencies.
ryoppippi
changed the title
ryoppippi
changed the title
jiti for dynamic import for svelte/compiler
ryoppippi
changed the title
jiti for dynamic import for svelte/compiler jiti for dynamic imports of svelte/compiler
fixes: #198
Summary by CodeRabbit