Bugfix for failing quotes, Login-screen, Force Azure off, Initial hidden "Hi" to have robot/assistant initiate dialog. #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for PR. |
|
This is not accepted because it contains code specific to your project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several fixes, but the one around line 190-199 is a critical bug-fix removing A LOT of crashes with the current OpenAI returned values. Sometimes the quotes are just not there and it fails.
Also added a couple of other less interesting things:
Also added ability to force Azure AI off, because I had the environment variables but did not want to use them.
Also hacked in the ability for the client to send a hidden "Hi!" (Hei in norwegian) message so that the robot/assistant starts with some message like: How can I help you today?
Sorry for mixing all these changes into one blob, but hope at least the bugfix can be incorporated!