Skip to content
This repository has been archived by the owner on Aug 12, 2020. It is now read-only.

Dont compile last version (go get -u github.com/rylio/ytdl/...) #86

Closed
JAVIERCUADROS7 opened this issue Jan 22, 2020 · 7 comments
Closed

Comments

@JAVIERCUADROS7
Copy link

github.com/rylio/ytdl/cmd/ytdl

../../go/src/github.com/rylio/ytdl/cmd/ytdl/main.go:51:17: cannot use cli.StringFlag literal (type cli.StringFlag) as type cli.Flag in array or slice literal:
cli.StringFlag does not implement cli.Flag (Apply method has pointer receiver)
../../go/src/github.com/rylio/ytdl/cmd/ytdl/main.go:56:15: cannot use cli.BoolFlag literal (type cli.BoolFlag) as type cli.Flag in array or slice literal:
cli.BoolFlag does not implement cli.Flag (Apply method has pointer receiver)
../../go/src/github.com/rylio/ytdl/cmd/ytdl/main.go:60:15: cannot use cli.BoolFlag literal (type cli.BoolFlag) as type cli.Flag in array or slice literal:
cli.BoolFlag does not implement cli.Flag (Apply method has pointer receiver)
../../go/src/github.com/rylio/ytdl/cmd/ytdl/main.go:64:15: cannot use cli.BoolFlag literal (type cli.BoolFlag) as type cli.Flag in array or slice literal:
cli.BoolFlag does not implement cli.Flag (Apply method has pointer receiver)
../../go/src/github.com/rylio/ytdl/cmd/ytdl/main.go:68:15: cannot use cli.BoolFlag literal (type cli.BoolFlag) as type cli.Flag in array or slice literal:
cli.BoolFlag does not implement cli.Flag (Apply method has pointer receiver)
../../go/src/github.com/rylio/ytdl/cmd/ytdl/main.go:72:22: cannot use cli.StringSliceFlag literal (type cli.StringSliceFlag) as type cli.Flag in array or slice literal:
cli.StringSliceFlag does not implement cli.Flag (Apply method has pointer receiver)
../../go/src/github.com/rylio/ytdl/cmd/ytdl/main.go:76:17: cannot use cli.StringFlag literal (type cli.StringFlag) as type cli.Flag in array or slice literal:
cli.StringFlag does not implement cli.Flag (Apply method has pointer receiver)
../../go/src/github.com/rylio/ytdl/cmd/ytdl/main.go:80:15: cannot use cli.BoolFlag literal (type cli.BoolFlag) as type cli.Flag in array or slice literal:
cli.BoolFlag does not implement cli.Flag (Apply method has pointer receiver)
../../go/src/github.com/rylio/ytdl/cmd/ytdl/main.go:84:15: cannot use cli.BoolFlag literal (type cli.BoolFlag) as type cli.Flag in array or slice literal:
cli.BoolFlag does not implement cli.Flag (Apply method has pointer receiver)
../../go/src/github.com/rylio/ytdl/cmd/ytdl/main.go:88:17: cannot use cli.StringFlag literal (type cli.StringFlag) as type cli.Flag in array or slice literal:
cli.StringFlag does not implement cli.Flag (Apply method has pointer receiver)
../../go/src/github.com/rylio/ytdl/cmd/ytdl/main.go:88:17: too many errors

@JAVIERCUADROS7 JAVIERCUADROS7 changed the title Dont compile last version Dont compile last version (go get -u github.com/rylio/ytdl/...) Jan 22, 2020
@corny
Copy link
Collaborator

corny commented Jan 23, 2020

This has stopped working since the migration of Go modules. See also golang/go#24250
To compile ytdl:

git clone [email protected]:rylio/ytdl.git
cd ytdl
go build ./cmd/ytdl

The binary is created in the current directory.

@wedojava
Copy link
Contributor

This has stopped working since the migration of Go modules. See also golang/go#24250
To compile ytdl:

git clone [email protected]:rylio/ytdl.git
cd ytdl
go build ./cmd/ytdl

The binary is created in the current directory.

Thanks, this worked for me.

@wedojava
Copy link
Contributor

@JAVIERCUADROS7 Hi, this worked for me: GO111MODULE=on go get -u -ldflags "-s -w" github.com/corny/ytdl/...

@wedojava wedojava mentioned this issue Mar 19, 2020
@shoce
Copy link

shoce commented Apr 6, 2020

🤷🏼‍♂️

; rm -rf $HOME/src/github.com/rylio/ytdl 

; go get -u github.com/rylio/ytdl/...
# github.com/rylio/ytdl/cmd/ytdl
src/github.com/rylio/ytdl/cmd/ytdl/main.go:51:17: cannot use cli.StringFlag literal (type cli.StringFlag) as type cli.Flag in slice literal:
	cli.StringFlag does not implement cli.Flag (Apply method has pointer receiver)
src/github.com/rylio/ytdl/cmd/ytdl/main.go:56:15: cannot use cli.BoolFlag literal (type cli.BoolFlag) as type cli.Flag in slice literal:
	cli.BoolFlag does not implement cli.Flag (Apply method has pointer receiver)
src/github.com/rylio/ytdl/cmd/ytdl/main.go:60:15: cannot use cli.BoolFlag literal (type cli.BoolFlag) as type cli.Flag in slice literal:
	cli.BoolFlag does not implement cli.Flag (Apply method has pointer receiver)
src/github.com/rylio/ytdl/cmd/ytdl/main.go:64:15: cannot use cli.BoolFlag literal (type cli.BoolFlag) as type cli.Flag in slice literal:
	cli.BoolFlag does not implement cli.Flag (Apply method has pointer receiver)
src/github.com/rylio/ytdl/cmd/ytdl/main.go:68:15: cannot use cli.BoolFlag literal (type cli.BoolFlag) as type cli.Flag in slice literal:
	cli.BoolFlag does not implement cli.Flag (Apply method has pointer receiver)
src/github.com/rylio/ytdl/cmd/ytdl/main.go:72:22: cannot use cli.StringSliceFlag literal (type cli.StringSliceFlag) as type cli.Flag in slice literal:
	cli.StringSliceFlag does not implement cli.Flag (Apply method has pointer receiver)
src/github.com/rylio/ytdl/cmd/ytdl/main.go:76:17: cannot use cli.StringFlag literal (type cli.StringFlag) as type cli.Flag in slice literal:
	cli.StringFlag does not implement cli.Flag (Apply method has pointer receiver)
src/github.com/rylio/ytdl/cmd/ytdl/main.go:80:15: cannot use cli.BoolFlag literal (type cli.BoolFlag) as type cli.Flag in slice literal:
	cli.BoolFlag does not implement cli.Flag (Apply method has pointer receiver)
src/github.com/rylio/ytdl/cmd/ytdl/main.go:84:15: cannot use cli.BoolFlag literal (type cli.BoolFlag) as type cli.Flag in slice literal:
	cli.BoolFlag does not implement cli.Flag (Apply method has pointer receiver)
src/github.com/rylio/ytdl/cmd/ytdl/main.go:88:17: cannot use cli.StringFlag literal (type cli.StringFlag) as type cli.Flag in slice literal:
	cli.StringFlag does not implement cli.Flag (Apply method has pointer receiver)
src/github.com/rylio/ytdl/cmd/ytdl/main.go:88:17: too many errors


; cd $HOME/src/github.com/rylio/ytdl


; go build -o $HOME/bin/ytdl ./cmd/ytdl
# github.com/rylio/ytdl/cmd/ytdl
cmd/ytdl/main.go:171:34: not enough arguments in call to client.GetVideoInfo
	have (string)
	want (context.Context, interface {})
cmd/ytdl/main.go:248:43: not enough arguments in call to client.GetDownloadURL
	have (*ytdl.VideoInfo, *ytdl.Format)
	want (context.Context, *ytdl.VideoInfo, *ytdl.Format)

r-novel added a commit to r-novel/ytdl that referenced this issue Apr 9, 2020
@r-novel
Copy link

r-novel commented Apr 9, 2020

@shoce PR: #96

welat09 added a commit to welat09/ytdl that referenced this issue Apr 11, 2020
@JAVIERCUADROS7
Copy link
Author

JAVIERCUADROS7 commented Apr 23, 2020 via email

@corny
Copy link
Collaborator

corny commented Jun 9, 2020

Please try the latest release.

@corny corny closed this as completed Jun 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants