Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transcripts don't support markdown #50

Closed
shirgoldbird opened this issue Aug 30, 2021 · 0 comments
Closed

Transcripts don't support markdown #50

shirgoldbird opened this issue Aug 30, 2021 · 0 comments

Comments

@shirgoldbird
Copy link

shirgoldbird commented Aug 30, 2021

Though the docs say transcripts support markdown, this wasn't the case when I tested. I added support by modifying the get_transcripts function in build_site.py: (lines 231-233)

  with open(path, "rb") as f:
      transcripts[language] = f.read().decode("utf-8").replace("\n", "<br>\n")
      transcripts[language] = MARKDOWN.convert(transcripts[language])

Happy to open a PR for this change but wanted to confirm first this is a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants