Skip to content

Commit

Permalink
add missing undefined to optional jsx keys (#346)
Browse files Browse the repository at this point in the history
* make optional key accept undefined

* improve types
  • Loading branch information
Huliiiiii authored Sep 3, 2024
1 parent b001675 commit eec3019
Showing 1 changed file with 12 additions and 6 deletions.
18 changes: 12 additions & 6 deletions packages/dom-expressions/src/jsx.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -600,7 +600,8 @@ export namespace JSX {
| "removals text"
| "text"
| "text additions"
| "text removals";
| "text removals"
| undefined;
/** Indicates that user input is required on the element before a form may be submitted. */
"aria-required"?: boolean | "false" | "true" | undefined;
/** Defines a human-readable, author-localized description for the role of an element. */
Expand Down Expand Up @@ -713,7 +714,8 @@ export namespace JSX {
| "tooltip"
| "tree"
| "treegrid"
| "treeitem";
| "treeitem"
| undefined;
}

// TODO: Should we allow this?
Expand Down Expand Up @@ -1312,7 +1314,8 @@ export namespace JSX {
| "alphabetic"
| "hanging"
| "mathematical"
| "inherit";
| "inherit"
| undefined;
"baseline-shift"?: number | string | undefined;
clip?: string | undefined;
"clip-path"?: string | undefined;
Expand All @@ -1335,7 +1338,8 @@ export namespace JSX {
| "mathematical"
| "hanging"
| "text-top"
| "inherit";
| "inherit"
| undefined;
"enable-background"?: string | undefined;
fill?: string | undefined;
"fill-opacity"?: number | string | "inherit" | undefined;
Expand Down Expand Up @@ -1375,7 +1379,8 @@ export namespace JSX {
| "stroke"
| "all"
| "none"
| "inherit";
| "inherit"
| undefined;
"shape-rendering"?:
| "auto"
| "optimizeSpeed"
Expand Down Expand Up @@ -1407,7 +1412,8 @@ export namespace JSX {
| "optimizeSpeed"
| "optimizeLegibility"
| "geometricPrecision"
| "inherit";
| "inherit"
| undefined;
"unicode-bidi"?: string | undefined;
visibility?: "visible" | "hidden" | "collapse" | "inherit" | undefined;
"word-spacing"?: number | string | undefined;
Expand Down

0 comments on commit eec3019

Please sign in to comment.