Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend FontNameReplacements for Anka/Coder #376

Merged
merged 1 commit into from
Oct 12, 2019

Conversation

gunman808
Copy link

Description

Please explain the changes you made here.

Requirements / Checklist

  • Read the Contributing Guidelines
  • Read or at least glanced at the FAQ
  • Read or at least glanced at the Wiki
  • Scripts execute without error (if necessary):
    • If any of the scripts were modified they have been tested and execute without error, e.g.:
      • ./font-patcher Inconsolata.otf --fontawesome --octicons --pomicons
      • ./gotta-patch-em-all-font-patcher\!.sh Hermit
  • [] Extended the README and documentation if necessary, e.g. You added a new font please update the table

What does this Pull Request (PR) do?

Renaming Anka/Coder font to AnaConder, so the script not run into an error because of the / in the name and comply with SIL Open Font License (OFL)

How should this be manually tested?

Any background context you can provide?

What are the relevant tickets (if any)?

Screenshots (if appropriate or helpful)

@ryanoasis
Copy link
Owner

@gunman808 Thank you for the PR.

I just want to be clear on 2 points 😄

  1. This is in preparation for complying with the SIL OFL license and particularly the Reserved Font Name for "Anka/Coder" ?

  2. I see you chose "AnaConder" as the new name? I think I'd be cool with it but wanted to know if any particular reason or was it just close enough?

@ryanoasis
Copy link
Owner

This is good for now. Thanks!

@ryanoasis ryanoasis merged commit 6da349c into ryanoasis:master Oct 12, 2019
@ryanoasis ryanoasis added this to the v2.1.0 milestone Oct 12, 2019
LNKLEO pushed a commit to LNKLEO/Nerd that referenced this pull request Nov 24, 2023
Extend FontNameReplacements for Anka/Coder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants