Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new version of Meslo with Regular/Bold/Italic/Bold-Italic variations #308

Merged
merged 4 commits into from
Feb 18, 2019

Conversation

segevfiner
Copy link
Contributor

@segevfiner segevfiner commented Dec 4, 2018

Description

Add a new version of Meslo with Regular/Bold/Italic/Bold-Italic variations.

I haven't tested the patched-fonts. Only manual patching of Meslo LG M, and I only tested loading it, and viewing some powerline prompt. When manually patching using --complete, the powerline symbols seem to be re-patched, which makes them look worse than the version in the unpatched font, and I think that happens for the fonts in patched-fonts too. See #307

The new Meslo fonts seem to already have the liga table stripped, so I removed the config.json.

Requirements / Checklist

  • Read the Contributing Guidelines
  • Read or at least glanced at the FAQ
  • Read or at least glanced at the Wiki
  • Scripts execute without error (if necessary):
    • If any of the scripts were modified they have been tested and execute without error, e.g.:
      • ./font-patcher Inconsolata.otf --fontawesome --octicons --pomicons
      • ./gotta-patch-em-all-font-patcher\!.sh Hermit
  • Extended the README and documentation if necessary, e.g. You added a new font please update the table

What does this Pull Request (PR) do?

Adds a new version of Meslo with Regular/Bold/Italic/Bold-Italic variations.

How should this be manually tested?

Like any other font. But you should also test the bold/italic/bold-italic variations.

What are the relevant tickets (if any)?

Fixes #302

@ryanoasis
Copy link
Owner

Will review

@ryanoasis ryanoasis merged commit 5271132 into ryanoasis:master Feb 18, 2019
@ryanoasis
Copy link
Owner

The new Meslo fonts seem to already have the liga table stripped, so I removed the config.json.

Great no problem, thanks.

Thank you for opening #307 (I was actually doing a bit of work on it weeks ago before pausing)

@ryanoasis ryanoasis added this to the v2.1.0 milestone Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants