This repository has been archived by the owner on Aug 4, 2021. It is now read-only.
Stateless Typed Components #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
First pass at getting stateless components working in the app. Jest tests are still failing though... @mikekidder |
The jest error around returning null / false was occuring because jest was mocking the new stateless component for us instead of actually rendering it with the fish component
|
Jest tests passing 🎉 turned out to be the framework was mocking the new stateless component rather then letting the fish component render it. |
|
@mikekidder thanks for the information around testing stateless components! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty happy with how supported stateless components are in tsx files!
Also nice to see the react dev tools for chrome showing the correct type.
Resources:
microsoft/TypeScript#5478
https://facebook.github.io/react/docs/reusable-components.html#stateless-functions
Issue: #22