Adjust for the viewport scrollX and scrollY #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getBoundingClientRect() returns coordinates relative to the viewport, so to position the portal clones exactly where the real nodes are, you have to adjust for the scrolling of the viewport.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this patch, if you scroll the basic example down and click the button to rearrange the boxes, the clones are rendered absolute to the document at the viewport coordinates of the real nodes.
This causes them to be rendered higher on the page than the real nodes, and it looks like the boxes are jumping.
To fix this we need to convert the viewport coordinates to document coordinates by adding the scroll position.
I was surprised how few lines of code magic move was, it's pretty neat what you can do with React with that few lines!