-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
samsonite.pl [Breakage] [FCL] #711
Comments
but widget block reload page - strange and silly... |
I just needed;
If someone can test that doesn't affect other parts of the site? |
It probably will not be problem, this is the typical background for this web plugin. |
"I don't care about cookies" will implement this instead, for greater precision and to allow other modals to have an overlay: |
I would be more worried if the store works without cookie permission accept than if I need to check if the message and the background are in the same parent (html element). |
I have not checked yet almost whether elements are immediately after to use the plus. Pseudo code CSS - what I mean (children next to each other): .ui-dialog.cookies-dialog + .ui-widget-overlay https://www.w3schools.com/cssref/sel_element_pluss.asp Does not work on this case, the elements are not directly behind each other. |
Simplified filters, generally will be faster. (like my initial commit) though if there is a better filter available I'm happy to modified it. |
I think Certainly from a logical point of view, it would be difficult to become <html>
<head class="ui-dialog cookies-dialog">
...
<head>
<body class="ui-widget-overlay">
...
<body>
</html> |
My filter will not be applied just on this website, hence the greater complexity. For global filters I always add :not(body):not(html) automatically because I've seen many websites where the developer, for god knows which reason, apply a cookie related classname to both body and html. |
But you're right, :not(body):not(html) is probably not needed in this case. |
As for me, in such a mix it is more sensible to check the first parameter and the second decisive is no longer like blocking as a |
personally not overusing :not(...) , and +/~ improves extension/browser performance, only really limited to problematic filters |
List the website(s) you're having issues:
https://www.samsonite.pl
What happens?
Breakage - the page won't load - shadow overlay
List Subscriptions you're using:
uBO default +
uBO annoyance +
Fanboy’s Cookiemonster List +
I don't care about cookies addon
Your settings
Other details:
Screenshoots:
screenshoot 1 - after enabling Fanboy’s Cookiemonster List and / or I don't care about cookies addon
screenshoot 2 - after disabling Fanboy’s Cookiemonster List and I don't care about cookies addon
screenshoot 3 - after accepting the message
Notes: just BTW FYI, I don't care about cookies addon is also affected - I've already sent the mail just right now.
The text was updated successfully, but these errors were encountered: