Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to node-sass@^4.7.2 #33

Closed

Conversation

ricardocasares
Copy link
Contributor

This provides a workaround to test case when an included mixin is called inside an standalone mixin.

@rootical
Copy link

Oh we need this actually as well... Thanks for the PR, @ricardocasares

@ricardocasares
Copy link
Contributor Author

@ryanbahniuk any comments on this?

@ryanbahniuk
Copy link
Owner

Is the bump to node-sass 4.7.2 required for this feature change?

@ricardocasares
Copy link
Contributor Author

ricardocasares commented Dec 20, 2017

@actually we just needed to update node-sass, but there is one test that fails on 4.7.2 because of #2245. Apparently, before it was possible to compile an included mixin even though the output was incorrect, ie: running @include appearance(none) outside any selectors, would not produce valid css.

Now node-sass is throwing this error, thus the test fails.

@alazurenko
Copy link

Would be great to have updated version of node-sass 🙂
What do you think @ryanbahniuk?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants