-
Notifications
You must be signed in to change notification settings - Fork 283
Update nifty_layout to be compatible with Rails 3.1 directory estructure and SCSS #109
base: master
Are you sure you want to change the base?
Conversation
More readable scss template
This looks really great, thank you! We should probably make this dynamic so it only happens when one is using Rails 3.1 that way it doesn't break Rails 3.0. What do you think? |
On 2 July 2011 13:50, ryanb
Oh, you're right, I didn't take that in mind =P. I guess the If it's okay I'll do it. |
That should work, you can just check if it starts with "3.0". There may be better ways, haven't looked. |
… not overwrite application.css on Rails 3.1
I tried to keep both versions (3.0.x and 3.1.x) on different gemsets using rvm, but for some reason I couldn't. They kept going back to the main gemset and being installed there. So, if Rails >=3.1.0 isn't installed the nifty_layout_3.1 feature is going to fail.
Sorry to keep you waiting :P. I've added the cucumber feature corresponding to the changes mlitwiniuk added. Since we're using two rails versions now, I tried that both versions (3.0.x and 3.1.x) would stay on different gemsets using rvm, but for some reason I couldn't. They kept going back to the main gemset and being installed there. So, if Rails >=3.1.0 isn't installed the nifty_layout_3.1 feature is going to fail. Any suggestion, commentary would be welcome :) |
@pablox-cl I downloaded your Git repository ,did bundle then rake.
@ryanb @pablox-cl How to tackle this? |
This pull request has 3 main points:
--scss
) to the nifty:layout generator to made possible to chose between the three (erb + css
,haml + sass
andhaml + scss
). Please, be free to change the option for whatever you find it's better.Regards,
PS.- I don't have too much experience in collaborating in other people projects so spare me if I did something wrong.