Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Privacy provider does not implement userlist #84

Closed
matthewhilton opened this issue Mar 30, 2023 · 2 comments
Closed

Privacy provider does not implement userlist #84

matthewhilton opened this issue Mar 30, 2023 · 2 comments

Comments

@matthewhilton
Copy link
Contributor

According to the Moodle docs:

https://moodledev.io/docs/apis/subsystems/privacy

In addition to these requirements, since Moodle 3.4.6, 3.5.3, any plugin which implements the plugin provider interface must also implement the \core_privacy\local\request\core_userlist_provider provider and implement functions:

get_users_in_context - to locate the users who hold any personal data in a specific context; and
delete_data_for_users - to delete data for multiple users in the specified context.

This test is failing:

1) core_privacy\privacy\provider_test::test_userdata_provider_implements_userlist with data set "mod_pdfannotator" ('mod_pdfannotator', 'mod_pdfannotator\privacy\provider')
Failed asserting that false is true.

/var/www/ec-41/privacy/tests/privacy/provider_test.php:213
/var/www/ec-41/lib/phpunit/classes/advanced_testcase.php:80
matthewhilton added a commit to catalyst/moodle-mod_pdfannotator that referenced this issue Mar 30, 2023
matthewhilton added a commit to catalyst/moodle-mod_pdfannotator that referenced this issue Mar 31, 2023
@nisaDoc
Copy link

nisaDoc commented Apr 5, 2023

Hi,

thx for using our issue and for the pull request you did for this problem.
we will check it.

Cheers,
Nisa

nisaDoc pushed a commit that referenced this issue May 23, 2023
nisaDoc pushed a commit that referenced this issue May 23, 2023
[#84] Fix userlist provider sql

See merge request moodle_l2p/moodle-mod_pdfannotator!218
@nisaDoc
Copy link

nisaDoc commented May 23, 2023

Hello,
new release is there with fix for this problem.
I added some changes into your PR. Thx for the PR

cheers
Nisa

@nisaDoc nisaDoc closed this as completed May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants