Fixed inconsistent hash_overwrite after copy_append and join_right #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertz
approved these changes
Jul 16, 2022
critias
force-pushed
the
fix_copy_append_hash_overwrite
branch
from
197ebb4 to
fcd3126
Compare
albertz
reviewed
Jul 16, 2022
Comment on lines
282
to
+286
| new = self.copy() | ||
| new.path = os.path.join(new.path, other) | ||
| if self.hash_overwrite: | ||
| c, o = self.hash_overwrite | ||
| new.hash_overwrite = (c, f"{o}/{other}") | ||
| new.path = f"{new.path}/{other}" |
There was a problem hiding this comment.
join_right could also simply be implemented as:
return self.copy_append("/" + other)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing issue #96