Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

for_all_nodes, handle exception/exit #234

Merged
merged 1 commit into from
Dec 17, 2024
Merged

for_all_nodes, handle exception/exit #234

merged 1 commit into from
Dec 17, 2024

Conversation

albertz
Copy link
Member

@albertz albertz commented Dec 16, 2024

Fix #164

NeoLegends
NeoLegends approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@NeoLegends NeoLegends left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, though I haven't checked very much in depth.

@albertz albertz merged commit 2376324 into master Dec 17, 2024
4 checks passed
@albertz albertz deleted the albert-manager-pool-proper-exit-164 branch December 17, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeoLegends NeoLegends NeoLegends approved these changes

@michelwi michelwi Awaiting requested review from michelwi

@critias critias Awaiting requested review from critias

@JackTemaki JackTemaki Awaiting requested review from JackTemaki

@Atticus1806 Atticus1806 Awaiting requested review from Atticus1806

@mmz33 mmz33 Awaiting requested review from mmz33

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash at exit
2 participants
@albertz @NeoLegends